Don't compare nullptr string - Fixes #120 #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In AdafruitIO_Group::call there is a comparison with the feedname of the update. If the onMessage() call didn't provide a feed name, the feed pointer is null. The code also checks for this, but it does it after comparing with a string. Reverse the check so a short-circuiting or can do the right thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In AdafruitIO_Group::call there is a comparison with the feedname
of the update. If the onMessage() call didn't provide a feed name,
the feed pointer is null. The code also checks for this, but
it does it after comparing with a string. Reverse the check
so a short-circuiting or can do the right thing.