-
Notifications
You must be signed in to change notification settings - Fork 51
[API v1]: Add support for I2C Output Components #751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@tyeth Re-requesting a review since I've incorporated your changes and added the SSD1306 driver to this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, can't wait to test it!
The OLED max hours comment is worth thinking about. I can imagine an action where a user displayed the new data for 5-30 minutes on schedule or button press/trigger, before turning off. Or could be hours based (daytime etc). Eventually dimmed at night would be cool (especially for alarm clocks)
This pull request enhances core I2C functionality by adding support for I2C output devices. This is a backport of #749 to work with the v1 WipperSnapper Protocol Buffer API.
The following I2C Output Devices are supported by this pull request:
Addresses: adafruit/Wippersnapper_Protobuf#144
Resolves: #742
Full Diff (Automatically Generated using Copilot Summary)
Support for New I2C Output Devices:
WipperSnapper_I2C_Driver_Out
,WipperSnapper_I2C_Driver_Out_QuadAlphaNum
, andWipperSnapper_I2C_Driver_Out_CharLcd
. These classes encapsulate the functionality required to interact with these devices. (src/components/i2c/drivers/WipperSnapper_I2C_Driver_Out.h
,src/components/i2c/drivers/WipperSnapper_I2C_Driver_Out_CharLcd.h
) [1] [2]Updates to I2C Initialization and Deinitialization:
initI2CDevice
to initialize the new output devices (quadalphanum
andcharlcd
) with specific configurations such as brightness and alignment for LED backpacks and row/column setup for character LCDs. (src/components/i2c/WipperSnapper_I2C.cpp
)deinitI2CDevice
to properly handle the removal of output drivers, ensuring compatibility with both ESP-IDF and Arduino architectures. (src/components/i2c/WipperSnapper_I2C.cpp
)Handling I2C Output Operations:
Handle_I2cDeviceOutputWrite
to process messages for output devices, including writing text or numeric values to LED backpacks and character LCDs. (src/components/i2c/WipperSnapper_I2C.cpp
,src/components/i2c/WipperSnapper_I2C.h
) [1] [2]Dependency Updates:
library.properties
andplatformio.ini
to include new dependencies for the Adafruit LED Backpack and LiquidCrystal libraries, ensuring the required libraries are available for the new functionality. (library.properties
,platformio.ini
) [1] [2]Debugging and Logging:
src/Wippersnapper.cpp
,src/components/i2c/WipperSnapper_I2C.cpp
) [1] [2]These changes significantly expand the WipperSnapper framework's capabilities, enabling support for a broader range of I2C devices and improving the overall robustness of the I2C handling logic.