Skip to content

fix: Add __init__.py for compoments folder in llm example #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 19, 2025

Conversation

piotrm-nvidia
Copy link
Contributor

Overview:

The init is necessary to used components folder in examples as Python packages.

Details:

The components folder in examples can be used as source of services to be served in dynamo:

dynamo serve components.prefill_worker:PrefillWorker -f configs/disagg.yaml

Where should the reviewer start?

Please check other init.py files and try to used dynamo server with files from components folder.

@piotrm-nvidia piotrm-nvidia changed the title Add __init__.py for compoments folder in llm example fix: Add __init__.py for compoments folder in llm example Mar 19, 2025
@piotrm-nvidia piotrm-nvidia marked this pull request as ready for review March 19, 2025 18:37
@piotrm-nvidia piotrm-nvidia enabled auto-merge (squash) March 19, 2025 18:37
@piotrm-nvidia piotrm-nvidia merged commit 37054b1 into main Mar 19, 2025
7 of 8 checks passed
@piotrm-nvidia piotrm-nvidia deleted the piotrm/init_for_examples branch March 19, 2025 18:40
kylehh pushed a commit to kylehh/dynamo that referenced this pull request Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants