fix: Revert "chore: Bump bentoml version to 1.4.6" #409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 172267d.
|
Interesting. They broke API with a patch version bump? |
|
@mohammedabdulwahhab this is the bentoml PR that renamed normalize_identifier into load: https://github.com/bentoml/BentoML/pull/5232/files |
dmitry-tokarev-nv
approved these changes
Mar 26, 2025
dmitry-tokarev-nv
deleted the
revert-404-dmitry-tokarev-nv-bentoml-upgrade
branch
kylehh
pushed a commit
to kylehh/dynamo
that referenced
this pull request
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #404
With the bentoml bump we are getting the following error, we will need to test with 1.4.6 before re-introducting this bump.
ImportError: cannot import name 'normalize_identifier' from '_bentoml_impl.loader' (/opt/dynamo/venv/lib/python3.12/site-packages/_bentoml_impl/loader.py)