Skip to content

feat: improve serve commands and expose DYNAMO_HOME env var #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 2, 2025

Conversation

jon-chuang
Copy link
Contributor

@jon-chuang jon-chuang commented Mar 29, 2025

Overview:

/workspace only exists on dockerized deployment.

Details:

Expose DYNAMO_HOME which is configured to /workspace within provided containers, and user-configurable for non-docker deployments

One may prefer a non-dockerized dev setup since even changing one line of python code results in 2 minutes of build time

image

Copy link

copy-pr-bot bot commented Mar 29, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Copy link

👋 Hi jon-chuang! Thank you for contributing to ai-dynamo/dynamo.

Just a reminder: The NVIDIA Test Github Validation CI runs an essential subset of the testing framework to quickly catch errors.Your PR reviewers may elect to test the changes comprehensively before approving your changes.

🚀

@github-actions github-actions bot added the external-contribution Pull request is from an external contributor label Mar 29, 2025
@ryanolson
Copy link
Contributor

/workspace is usually the name of our working directory inside a container.

We should update the instructions to use a DYNAMO_HOME env, then set that env in the container to point at where ever our WORKDIR in the image is set.

Thanks again for helping!

@jon-chuang jon-chuang requested a review from a team as a code owner March 29, 2025 22:10
@jon-chuang jon-chuang changed the title fix: fix serve commands feat: improve serve commands and expose DYNAMO_HOME env var Mar 29, 2025
@nnshah1
Copy link
Contributor

nnshah1 commented Apr 1, 2025

One may prefer a non-dockerized dev setup since even changing one line of python code results in 2 minutes of build time

image

One other option for local dev is also to mount into the container and pip install the packages as editable:

./container/run.sh --mount-workspace -it
cd /workspace/lib/bindings/python
uv pip install -e .
...

@jon-chuang
Copy link
Contributor Author

One other option for local dev is also to mount into the container and pip install the packages as editable:

Cool. I think that is preferable because the VLLM patches and NIXL build are pain points that can be avoided with that workflow.

Would be cool if there is first class support for that

@jon-chuang
Copy link
Contributor Author

I saw this PR added instructions for it. #463
Glad to see it!

@nnshah1 nnshah1 merged commit 43ac869 into ai-dynamo:main Apr 2, 2025
6 checks passed
kylehh pushed a commit to kylehh/dynamo that referenced this pull request Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external-contribution Pull request is from an external contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants