-
Notifications
You must be signed in to change notification settings - Fork 348
feat: improve serve commands and expose DYNAMO_HOME
env var
#436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hi jon-chuang! Thank you for contributing to ai-dynamo/dynamo. Just a reminder: The 🚀 |
/workspace is usually the name of our working directory inside a container. We should update the instructions to use a DYNAMO_HOME env, then set that env in the container to point at where ever our WORKDIR in the image is set. Thanks again for helping! |
DYNAMO_HOME
env var
One other option for local dev is also to mount into the container and pip install the packages as editable:
|
Cool. I think that is preferable because the VLLM patches and NIXL build are pain points that can be avoided with that workflow. Would be cool if there is first class support for that |
I saw this PR added instructions for it. #463 |
…amo#436) Co-authored-by: Ryan Olson <[email protected]>
Overview:
/workspace only exists on dockerized deployment.
Details:
Expose
DYNAMO_HOME
which is configured to/workspace
within provided containers, and user-configurable for non-docker deploymentsOne may prefer a non-dockerized dev setup since even changing one line of python code results in 2 minutes of build time