feat(dynamo-run): Basic routing choice #524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grahamking
requested review from
nnshah1,
tanmayv25,
piotrm-nvidia,
ptarasiewiczNV,
ryanolson,
paulhendricks,
biswapanda,
tmonty12,
GuanLuo,
rmccorm4,
tedzhouhk,
alec-flowers,
kkranen and
a team
as code owners
grahamking
force-pushed
the
gk-basic-routing
branch
from
664fbdc to
a368959
Compare
grahamking
force-pushed
the
gk-basic-routing
branch
from
a368959 to
a4d3394
Compare
As a first step towards KV routing: - introduce a `--router-mode` in dynamo-run that only does random and round-robin right now. Not that interesting yet. - Make the vllm engine publish the KV events received from our patched vllm. Now we "just" need to connect the two. Easy right?
grahamking
force-pushed
the
gk-basic-routing
branch
from
a4d3394 to
8cdccca
Compare
rmccorm4
reviewed
Apr 7, 2025
rmccorm4
reviewed
Apr 7, 2025
rmccorm4
approved these changes
Apr 7, 2025
There was a problem hiding this comment.
random/round-robin router inclusion changes LGTM.
I'm curious to see how we can get to a consistent story across dynamo run and dynamo serve/deploy for KV Routing, as well as consistent naming/schemes for discovery for things like metrics/grafana/observability.
kylehh
pushed a commit
to kylehh/dynamo
that referenced
this pull request
Apr 11, 2025
As a first step towards KV routing: - introduce a `--router-mode` in dynamo-run that only does random and round-robin right now. Not that interesting yet. - Make the vllm engine publish the KV events received from our patched vllm. Now we "just" need to connect the two. Easy right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a first step towards KV routing:
--router-modein dynamo-run that only does random and round-robin right now. Not that interesting yet.Now we "just" need to connect the two. Easy right?