Skip to content

fix: clean unused bento pieces from serve.py and serving.py #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
Apr 7, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
06054e0
init
ishandhanani Apr 4, 2025
eea4c4c
pre
ishandhanani Apr 4, 2025
754159d
more logging vs print
ishandhanani Apr 4, 2025
f741da1
bump logging
ishandhanani Apr 4, 2025
7f9919a
copywrite
ishandhanani Apr 4, 2025
58123ed
remove wack lowercase message
ishandhanani Apr 4, 2025
20ea1c6
Merge branch 'main' into ishan/unify-logging-examples
ishandhanani Apr 4, 2025
02e16f7
components and utils
ishandhanani Apr 4, 2025
0543ad4
pre
ishandhanani Apr 4, 2025
624d123
bump
ishandhanani Apr 4, 2025
90d7010
clean
ishandhanani Apr 4, 2025
c25afc4
bump
ishandhanani Apr 4, 2025
c07acc2
Merge branch 'main' into ishan/unify-logging-examples
ishandhanani Apr 5, 2025
f3597d8
Merge branch 'main' into ishan/unify-logging-examples
ishandhanani Apr 6, 2025
0fe6144
remove start
ishandhanani Apr 7, 2025
affa5d7
Merge branch 'ishan/unify-logging-examples' into ishan/cleanup-serve
ishandhanani Apr 7, 2025
d5ba3bd
serve.py clean
ishandhanani Apr 7, 2025
ce6d820
bring back accidental remove
ishandhanani Apr 7, 2025
2476afa
pre
ishandhanani Apr 7, 2025
a8aa675
clean serving
ishandhanani Apr 7, 2025
cd56c5c
bump bento to 1.4.7
ishandhanani Apr 7, 2025
eb53a92
bento bump
ishandhanani Apr 7, 2025
446514e
log
ishandhanani Apr 7, 2025
45ad74c
warnings
ishandhanani Apr 7, 2025
72d4917
mypy1
ishandhanani Apr 7, 2025
7bc353d
mypy2
ishandhanani Apr 7, 2025
fa71597
Merge branch 'main' into ishan/cleanup-serve
ishandhanani Apr 7, 2025
68261ea
ack
ishandhanani Apr 7, 2025
d5005b9
ack2
ishandhanani Apr 7, 2025
5c836de
Merge branch 'main' into ishan/cleanup-serve
mohammedabdulwahhab Apr 7, 2025
29ee237
Merge branch 'main' into ishan/cleanup-serve
mohammedabdulwahhab Apr 7, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions deploy/dynamo/sdk/src/dynamo/sdk/cli/cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ def create_bentoml_cli() -> click.Command:
from dynamo.sdk.cli.run import run_command
from dynamo.sdk.cli.serve import serve_command
from dynamo.sdk.cli.server import cloud_command
from dynamo.sdk.cli.start import start_command
from dynamo.sdk.cli.utils import DynamoCommandGroup

# from dynamo.sdk.cli.cloud import cloud_command
Expand All @@ -60,7 +59,6 @@ def bentoml_cli(): # TODO: to be renamed to something....
# Add top-level CLI commands
bentoml_cli.add_command(cloud_command)
bentoml_cli.add_single_command(bento_command, "build")
bentoml_cli.add_subcommands(start_command)
bentoml_cli.add_subcommands(serve_command)
bentoml_cli.add_subcommands(run_command)
# bentoml_cli.add_command(deploy_command)
Expand Down
2 changes: 1 addition & 1 deletion deploy/dynamo/sdk/src/dynamo/sdk/cli/deploy.py
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ def deploy_command(
- a tag to a Bento in local Bento store
- a path to a built Bento
"""
from bentoml._internal.log import configure_server_logging
from dynamo.sdk.lib.logging import configure_server_logging

configure_server_logging()

Expand Down
2 changes: 1 addition & 1 deletion deploy/dynamo/sdk/src/dynamo/sdk/cli/deployment.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
from rich.table import Table
from simple_di import Provide, inject

logger = logging.getLogger("dynamo.deployment")
logger = logging.getLogger(__name__)

if t.TYPE_CHECKING:
from bentoml._internal.cloud import BentoCloudClient
Expand Down
Loading
Loading