-
Notifications
You must be signed in to change notification settings - Fork 337
feat: Add manylinux support for Dynamo #536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Pavithra Vijayakrishnan <[email protected]>
Signed-off-by: Pavithra Vijayakrishnan <[email protected]>
Signed-off-by: Pavithra Vijayakrishnan <[email protected]>
Signed-off-by: Pavithra Vijayakrishnan <[email protected]>
Signed-off-by: Pavithra Vijayakrishnan <[email protected]>
Signed-off-by: Pavithra Vijayakrishnan <[email protected]>
Signed-off-by: Pavithra Vijayakrishnan <[email protected]>
Signed-off-by: Pavithra Vijayakrishnan <[email protected]>
Signed-off-by: Pavithra Vijayakrishnan <[email protected]>
/ok to test |
Signed-off-by: Pavithra Vijayakrishnan <[email protected]>
Signed-off-by: Pavithra Vijayakrishnan <[email protected]>
/ok to test |
For clarification, this change will go from producing wheels which are built with ubuntu 24.04 to only building wheels with the manylinux image? Is this what the dynamo team wants, a strict replace, or do they want two sets of wheels, one for the latest ubuntu and one for manylinux? |
Signed-off-by: Pavithra Vijayakrishnan <[email protected]>
Signed-off-by: Pavithra Vijayakrishnan <[email protected]>
/ok to test |
Thanks @nv-kmcgill53. Yes, the new changes will build only the wheels in a Manylinux environment with glibc v2.28. This means the target system will need to have glibc v2.28 or later to install the wheels. Since Ubuntu 24.04 uses glibc v2.39, there should not be a problem. |
Signed-off-by: Pavithra Vijayakrishnan <[email protected]>
Signed-off-by: Pavithra Vijayakrishnan <[email protected]>
/ok to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - I think we should as a follow up document our stage names / uses more - but I think that will be separate from this
Signed-off-by: Pavithra Vijayakrishnan <[email protected]>
Signed-off-by: Pavithra Vijayakrishnan <[email protected]>
Overview:
Generate wheels for vLLM and TRTLLM using a Manylinux-compatible image.
Details:
Created a new wheel building stage in the Dockerfile for vllm and TRTLLM frameworks.
Where should the reviewer start?
Dockerfile.vllm and Dockerfile.trtllm