Skip to content

feat: Add manylinux support for Dynamo #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Apr 9, 2025

Conversation

pvijayakrish
Copy link
Contributor

Overview:

Generate wheels for vLLM and TRTLLM using a Manylinux-compatible image.

Details:

Created a new wheel building stage in the Dockerfile for vllm and TRTLLM frameworks.

Where should the reviewer start?

Dockerfile.vllm and Dockerfile.trtllm

Signed-off-by: Pavithra Vijayakrishnan <[email protected]>
Signed-off-by: Pavithra Vijayakrishnan <[email protected]>
Signed-off-by: Pavithra Vijayakrishnan <[email protected]>
Signed-off-by: Pavithra Vijayakrishnan <[email protected]>
@pvijayakrish pvijayakrish changed the title Add manylinux support for Dynamo feat: Add manylinux support for Dynamo Apr 7, 2025
Signed-off-by: Pavithra Vijayakrishnan <[email protected]>
Signed-off-by: Pavithra Vijayakrishnan <[email protected]>
Signed-off-by: Pavithra Vijayakrishnan <[email protected]>
Signed-off-by: Pavithra Vijayakrishnan <[email protected]>
Copy link

copy-pr-bot bot commented Apr 8, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@pvijayakrish pvijayakrish marked this pull request as ready for review April 8, 2025 18:49
@pvijayakrish
Copy link
Contributor Author

/ok to test

Signed-off-by: Pavithra Vijayakrishnan <[email protected]>
Signed-off-by: Pavithra Vijayakrishnan <[email protected]>
@pvijayakrish
Copy link
Contributor Author

/ok to test

@nv-kmcgill53
Copy link

For clarification, this change will go from producing wheels which are built with ubuntu 24.04 to only building wheels with the manylinux image? Is this what the dynamo team wants, a strict replace, or do they want two sets of wheels, one for the latest ubuntu and one for manylinux?

@pvijayakrish
Copy link
Contributor Author

/ok to test

@pvijayakrish
Copy link
Contributor Author

For clarification, this change will go from producing wheels which are built with ubuntu 24.04 to only building wheels with the manylinux image? Is this what the dynamo team wants, a strict replace, or do they want two sets of wheels, one for the latest ubuntu and one for manylinux?

Thanks @nv-kmcgill53. Yes, the new changes will build only the wheels in a Manylinux environment with glibc v2.28. This means the target system will need to have glibc v2.28 or later to install the wheels. Since Ubuntu 24.04 uses glibc v2.39, there should not be a problem.

Signed-off-by: Pavithra Vijayakrishnan <[email protected]>
Signed-off-by: Pavithra Vijayakrishnan <[email protected]>
@pvijayakrish
Copy link
Contributor Author

/ok to test

@pvijayakrish pvijayakrish requested a review from nnshah1 April 8, 2025 22:54
Copy link
Contributor

@nnshah1 nnshah1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I think we should as a follow up document our stage names / uses more - but I think that will be separate from this

@pvijayakrish pvijayakrish merged commit 7e50816 into main Apr 9, 2025
9 checks passed
@pvijayakrish pvijayakrish deleted the pvijayakrish/manylinux-support branch April 9, 2025 00:21
kylehh pushed a commit to kylehh/dynamo that referenced this pull request Apr 11, 2025
oandreeva-nv pushed a commit that referenced this pull request Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants