Skip to content

docs: Clarify the --max-local-prefill-length help description #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 9, 2025

Conversation

kthui
Copy link
Contributor

@kthui kthui commented Apr 8, 2025

Overview:

Update the --max-local-prefill-length description making it more descriptive on what it does, and align the description style with the --max-prefill-queue-size below.

Details:

N/A

Where should the reviewer start?

N/A

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

Copy link

copy-pr-bot bot commented Apr 8, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@kthui kthui enabled auto-merge (squash) April 8, 2025 22:23
@kthui kthui self-assigned this Apr 8, 2025
Co-authored-by: Neelay Shah <[email protected]>
Signed-off-by: Jacky <[email protected]>
Copy link
Contributor

@nnshah1 nnshah1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - and makes it clearer.

@kthui kthui disabled auto-merge April 8, 2025 23:26
@kthui kthui enabled auto-merge (squash) April 8, 2025 23:26
Co-authored-by: Tanmay Verma <[email protected]>
Signed-off-by: Jacky <[email protected]>
Co-authored-by: Tanmay Verma <[email protected]>
Signed-off-by: Jacky <[email protected]>
@kthui kthui merged commit ce4aab0 into main Apr 9, 2025
5 checks passed
@kthui kthui deleted the jacky-vllm-max-local-prefill-length-docs branch April 9, 2025 00:08
kylehh pushed a commit to kylehh/dynamo that referenced this pull request Apr 11, 2025
oandreeva-nv pushed a commit that referenced this pull request Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants