fix(ie11): replace Object.assign and Array.from. #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ritz078
changed the title
ljharb
requested changes
Mar 16, 2018
There was a problem hiding this comment.
It’s expected that you’re using https://npmjs.com/airbnb-browser-shims in your app; separately, the compiler doesn’t run in browsers so I’m not sure it needs any treatment.
| @@ -49,7 +49,8 @@ | |||
| "dependencies": { | |||
| "aphrodite": "^1.2.5", | |||
| "array.prototype.flatten": "^1.2.1", | |||
| "global-cache": "^1.2.1" | |||
| "global-cache": "^1.2.1", | |||
| "object-assign": "^4.1.1" | |||
There was a problem hiding this comment.
First, please use object.assign, not the hyphen one - but second, this can be done with a babel transform (see react-dates for an example) and then it will also work for object spreads.
| @@ -54,6 +54,7 @@ | |||
| }, | |||
| "dependencies": { | |||
| "aphrodite": "^1.2.4", | |||
| "array-from": "^2.1.1", | |||
There was a problem hiding this comment.
This module polyfills the environment, so we must not use it.
This is not documented in the readme, but should be |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Object.assignis not supported on IE11