Configure sbt-header and update Lightbend copyright headers #1738

jonas · 2018-01-03T02:04:07Z

jonas · 2018-01-03T02:06:59Z

project/CopyrightHeader.scala

+      Seq(
+        includeFilter in headerCreate := (includeFilter in unmanagedSources).value,
+        excludeFilter in headerCreate := (excludeFilter in unmanagedSources).value,
+        unmanagedSources in headerCreate := Defaults.collectFiles(


@hseeberger As mentioned in sbt/sbt-header#147 I could not get excludeFilter.in(unmanagedSources.in(headerCreate)) to work. It could be the lack of configuration scope however, the sbt-header code doesn't seem to use Defaults.collectFiles or something similar to apply these filters. Is this a bug?

jonas · 2018-01-03T02:13:50Z

project/CopyrightHeader.scala

+          excludeFilter in headerCreate
+        ).value,
+        headerLicense := Some(HeaderLicense.Custom(
+          """|Copyright (C) 2009-2018 Lightbend Inc. <https://www.lightbend.com>


Not sure whether to use http:// or https:// and ending / or not.

akka-ci · 2018-01-03T02:18:52Z

Test PASSed.

jonas · 2018-01-03T03:50:45Z

project/CopyrightHeader.scala

+            excludeFilter in headerCreate
+          ).value,
+          headerLicense := Some(HeaderLicense.Custom(
+            """|Copyright (C) 2009-2018 Lightbend Inc. <https://www.lightbend.com>


[rebased so recommenting]

Please confirm whether using https:// is OK.

Yes, please! :)

jonas · 2018-01-03T03:52:16Z

project/CopyrightHeader.scala

+        Seq(
+          includeFilter in headerCreate := (includeFilter in unmanagedSources).value,
+          excludeFilter in headerCreate := (excludeFilter in unmanagedSources).value,
+          unmanagedSources in headerCreate := Defaults.collectFiles(


@hseeberger (Sorry to ping you twice) As mentioned in sbt/sbt-header#147 I could not get excludeFilter.in(unmanagedSources.in(headerCreate)) to work. It could be the lack of configuration scope however, the sbt-header code doesn't seem to use Defaults.collectFiles or something similar to apply these filters. Is this a bug?

Probably a Bug/missing feature.

jonas · 2018-01-03T03:53:07Z

build.sbt

@@ -57,6 +57,7 @@ lazy val root = Project(
  .settings(
    // Unidoc doesn't like macros
    unidocProjectExcludes := Seq(parsing),
+    unmanagedSources in (Compile, headerCreate) := (baseDirectory.value / "project").**("*.scala").get,


Manage sbt project file headers as part of the root project.

akka-ci · 2018-01-03T03:57:21Z

Test PASSed.

raboof · 2018-01-03T08:58:23Z

Hmm I wonder if we want to update all years, or try to preserve them (using https://github.com/sbt/sbt-header#custom-comment-creators)

jlprat · 2018-01-03T09:08:21Z

akka-http-caching/src/main/java/akka/http/caching/javadsl/Cache.java

-/**
- * Copyright (C) 2017 Lightbend Inc. <http://www.lightbend.com/>
+/*
+ * Copyright (C) 2009-2018 Lightbend Inc. <https://www.lightbend.com>


AFAIU the year range was meant to keep track of when the file was created. For example, Cache was created on 2017, so this year should be 2017-2018. Is this something legal? Or just a good thing to have?

A nice to have AFAIR. We can use the automatic template hm

AFAIU the year range was meant to keep track of when the file was created. For example, Cache was created on 2017, so this year should be 2017-2018. Is this something legal? Or just a good thing to have?

That's one way to use/interpret them but it seems that Akka uses the convention to use the same headers everywhere (e.g. akka/akka@6c70852 where everything was changed to 2017). It would make sense to keep it consistent between Akka sub-projects. When it comes to history, there's always the commit history as the ultimate truth.

jrudolph · 2018-01-03T12:47:53Z

build.sbt

@@ -91,6 +93,11 @@ lazy val httpCore = project("akka-http-core")
  .settings(Dependencies.httpCore)
  .settings(VersionGenerator.versionSettings)
  .enablePlugins(BootstrapGenjavadoc)
+  .settings(
+    excludeFilter in (Compile, headerCreate) :=
+      "LastEventId.*" || "ServerSentEvent.*" || "Base64Parsing.scala" || "StringBuilding.scala",


Hmm, that seems quite brittle to me. The plugin shouldn't touch any files that are not yet copyright Lightbend. Can we do that somehow?

It looks like we can match on the previous header text and update accordingly. Will give it a try.

Access to existing headers was added by @raboof in sbt/sbt-header#142 and has not yet been released. Since it simplifies a lot I suggest we wait until a new release is out.

sbt-header 4.1.0 has been released. I'll update the PR to get rid of the excludes.

jonas · 2018-01-10T03:50:48Z

The years are now preserved. Additional text in the Lightbend copyright headers are not preserved however. There was one such header.

This also detected one Typesafe copyright header and several missing headers (mainly in *Spec files).

akka-ci · 2018-01-10T04:00:32Z

Test FAILed.

jonas · 2018-01-10T14:46:30Z

PLS BUILD

…ghts

Based on the following sbt tasks: > compile:headerCreate > test:headerCreate > multi-jvm:headerCreate

akka-ci · 2018-01-19T01:41:03Z

Test FAILed.

jonas · 2018-01-19T02:09:15Z

Only Lightbend copyright notices are touched as of the latest version.

akka-ci · 2018-01-19T02:47:37Z

Test PASSed.

jrudolph · 2018-01-29T10:54:57Z

Great stuff, thanks a lot, @jonas. It will help a lot in upcoming years!

ktoso · 2018-01-29T11:24:28Z

Late to the party but this is fantastic, thanks a lot :)

… copyright headers (akka#1738) * Fix akka#1255: Configure sbt-header * Update Lightbend copyright headers Based on the following sbt tasks: > compile:headerCreate > test:headerCreate > multi-jvm:headerCreate

jonas commented Jan 3, 2018

View reviewed changes

akka-ci added the validating PR that is currently being validated by Jenkins label Jan 3, 2018

jonas commented Jan 3, 2018

View reviewed changes

akka-ci added tested PR that was successfully built and tested by Jenkins and removed validating PR that is currently being validated by Jenkins labels Jan 3, 2018

jonas force-pushed the sbt-header branch from 3e37dd1 to f49cf86 Compare January 3, 2018 03:48

akka-ci added validating PR that is currently being validated by Jenkins and removed tested PR that was successfully built and tested by Jenkins labels Jan 3, 2018

jonas commented Jan 3, 2018

View reviewed changes

akka-ci added tested PR that was successfully built and tested by Jenkins and removed validating PR that is currently being validated by Jenkins labels Jan 3, 2018

jlprat reviewed Jan 3, 2018

View reviewed changes

jrudolph reviewed Jan 3, 2018

View reviewed changes

jonas force-pushed the sbt-header branch from f49cf86 to 5e3ebad Compare January 10, 2018 03:47

akka-ci added validating PR that is currently being validated by Jenkins and removed tested PR that was successfully built and tested by Jenkins labels Jan 10, 2018

akka-ci added needs-attention Indicates a PR validation failure (set by CI infrastructure) and removed validating PR that is currently being validated by Jenkins labels Jan 10, 2018

jonas mentioned this pull request Jan 10, 2018

FAILED: akka.http.impl.engine.client.HostConnectionPoolSpec.NewPoolImplementation on AkkaHttpEngineNoNetwork should fail a request if the connection stream fails while waiting for request entity bytes #1757

Closed

akka-ci added validating PR that is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed needs-attention Indicates a PR validation failure (set by CI infrastructure) labels Jan 10, 2018

jonas added 5 commits January 18, 2018 19:32

Check copyright headers when validating pull requests

7a136fb

Update copyrights in files not managed by sbt-header

9e9fa29

Rewrite to use existing header to selectively update Lightbend copyri…

64b1760

…ghts

Update Lightbend copyright headers

f3c948f

Based on the following sbt tasks: > compile:headerCreate > test:headerCreate > multi-jvm:headerCreate

Revert StageLoggingWithOverride copyright header

015c578

jonas force-pushed the sbt-header branch from 5e3ebad to b056560 Compare January 19, 2018 01:27

akka-ci added validating PR that is currently being validated by Jenkins needs-attention Indicates a PR validation failure (set by CI infrastructure) and removed tested PR that was successfully built and tested by Jenkins validating PR that is currently being validated by Jenkins labels Jan 19, 2018

jonas added 2 commits January 18, 2018 20:54

Leave anything other than the Lightbend copyright notice unchanged

a516384

Update copyright header in WithLogCapturing

a7104ab

jonas force-pushed the sbt-header branch from b056560 to a7104ab Compare January 19, 2018 02:06

akka-ci added validating PR that is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed needs-attention Indicates a PR validation failure (set by CI infrastructure) validating PR that is currently being validated by Jenkins labels Jan 19, 2018

jrudolph merged commit f3e8393 into akka:master Jan 29, 2018

jonas deleted the sbt-header branch January 29, 2018 14:38

ktoso mentioned this pull request Feb 21, 2018

Issue 24519: Created method lazilyAsync for both DSLs and adds section in docs akka/akka#24568

Merged

kelebra mentioned this pull request Feb 22, 2018

Added integration with sbt-header like in akka-http akka/akka#24594

Closed

dwijnand mentioned this pull request Mar 16, 2018

Preserve copyright years sbt/sbt-header#23

Open

adriaanm mentioned this pull request Aug 28, 2018

Use sbt-header to add apache-2.0 license notice to source files scala/scala-dev#549

Closed

Configure sbt-header and update Lightbend copyright headers #1738

Configure sbt-header and update Lightbend copyright headers #1738

Uh oh!

Conversation

jonas commented Jan 3, 2018

Uh oh!

jonas Jan 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

akka-ci commented Jan 3, 2018

Uh oh!

jonas Jan 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jonas Jan 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

akka-ci commented Jan 3, 2018

Uh oh!

raboof commented Jan 3, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jrudolph Jan 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jonas commented Jan 10, 2018

Uh oh!

akka-ci commented Jan 10, 2018

Uh oh!

jonas commented Jan 10, 2018

Uh oh!

akka-ci commented Jan 19, 2018

Uh oh!

jonas commented Jan 19, 2018

Uh oh!

akka-ci commented Jan 19, 2018

Uh oh!

jrudolph commented Jan 29, 2018

Uh oh!

ktoso commented Jan 29, 2018

Uh oh!

Uh oh!

jonas Jan 3, 2018 •

edited

Loading

jonas Jan 3, 2018 •

edited

Loading

jonas Jan 3, 2018 •

edited

Loading

jrudolph Jan 3, 2018 •

edited

Loading