Skip to content

feat(recommend): support multiple queries #1283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2021

Conversation

francoischalifour
Copy link
Member

Description

Before releasing the new Recommend API client, we changed the API to support multi-query on the methods. The methods only accept arrays now.

Usage

import algoliarecommend from '@algolia/recommend';

const recommendClient = algoliarecommend('appId', 'apiKey');

recommendClient
  .getRelatedProducts([
    {
      /* ... */
    },
  ])
  .then((response) => {
    console.log(response);
  });

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean!

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ec28d96:

Sandbox Source
javascript-client-app Configuration

@@ -22,16 +22,14 @@ type GetRecommendations = (
) => WithRecommendMethods<RecommendClient>['getRecommendations'];

export const getRecommendations: GetRecommendations = base => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we let users know that sending multiple queries with different model is not the expected behavior?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would work as expected. However, in our AI components, we won't mix multiple models.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok!

Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much better, glad you kept only one type (all plural)

@francoischalifour francoischalifour changed the title feat(recommend): support multi-query feat(recommend): support multiple queries Jun 23, 2021
@francoischalifour francoischalifour merged commit 5cf64dd into master Jun 23, 2021
@francoischalifour francoischalifour deleted the feat/recommend-multi-query branch June 23, 2021 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants