-
Notifications
You must be signed in to change notification settings - Fork 223
feat(recommend): support multiple queries #1283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks clean!
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ec28d96:
|
@@ -22,16 +22,14 @@ type GetRecommendations = ( | |||
) => WithRecommendMethods<RecommendClient>['getRecommendations']; | |||
|
|||
export const getRecommendations: GetRecommendations = base => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we let users know that sending multiple queries with different model is not the expected behavior?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would work as expected. However, in our AI components, we won't mix multiple models.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
much better, glad you kept only one type (all plural)
Description
Before releasing the new Recommend API client, we changed the API to support multi-query on the methods. The methods only accept arrays now.
Usage