Error in Tree Traversal code c#

[xam4lor]

The function DFSStack() for the Tree Traversal's example is missing a parameter of type "Node" called "root".

[june128]

I'll look into it and come back to you! :)

[june128]

You're right. Currently the root gets set by the constructor, which will just make up a "fake" Tree.
Making the methods accessible from the outside and really use the algorithm is a good idea actually. We should probably switch the algorithm over to do so.

[xam4lor]

I think so ! It's not very clear, the way it's made right now !

[june128]

Yeah it's definitely a flaw! I'll go ahead and change it. Or do you want to (I don't want to take away your issue)?

[xam4lor]

Let's go do it by myself ;)
I'm new at opensources projects, so it's a good exercice :)

[xam4lor]

Should I do it for every methods ? And just delete the global Node ?

[june128]

Yes, but I currently have a PR changing TreeTraversal open. Since you know C#, would you mind to review it and work on the new master? Otherwise you can of course just work on the current master and I update my PR. (PR: #120)

[xam4lor]

I'm sorry but I don't really know how to do that :/