Skip to content

Re-added tree traversal in Haskell, pre/post/in-order #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2018
Merged

Re-added tree traversal in Haskell, pre/post/in-order #111

merged 1 commit into from
May 30, 2018

Conversation

jiegillet
Copy link
Member

  • tree traversal in Haskell, it had submitted it before but it got lost
  • added post-order
  • added in-order, although I'm not super happy with this since it could cause an error. See the issue that I opened about this (how do you link those things?)
  • added code snippets into tree_traversal.md, fixed a typo and trailing whitespaces.
  • I have not implemented the stack method, it's basically impossible to avoid recursion in Haskell anyway

@Gathros Gathros added Implementation This provides an implementation for an algorithm. (Code and maybe md files are edited.) Chapter Edit This changes the archive's chapters. (md files are edited.) labels May 14, 2018
leios
leios approved these changes May 30, 2018
View reviewed changes
Copy link
Member

@leios leios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed these changes in person.

I only had a few questions about the use of forest for a group of trees and the test tree example, but these are common enough notationally

@leios leios merged commit 2781574 into algorithm-archivists:master May 30, 2018
@june128 june128 removed the Chapter Edit This changes the archive's chapters. (md files are edited.) label Jun 11, 2018
@jiegillet jiegillet deleted the treeHaskell branch August 4, 2018 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leios leios leios approved these changes

Assignees
No one assigned
Labels
Implementation This provides an implementation for an algorithm. (Code and maybe md files are edited.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jiegillet @leios @Gathros @june128