Skip to content

Fix links to not point to the old repository anymore and remove a file that shouldn't be here. #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 29, 2018

Conversation

june128
Copy link
Member

@june128 june128 commented May 29, 2018

Every instance of "leios/algorithm-archive" is being replaced with "algorithm-archivists/algorithm-archive".

@june128
Copy link
Member Author

june128 commented May 29, 2018

@leios What's up with version_control.md2? Is this file important/used?

@june128 june128 added the Chapter Edit This changes the archive's chapters. (md files are edited.) label May 29, 2018
@leios
Copy link
Member

leios commented May 29, 2018

@julianschacher That was a mistake. It can definitely be deleted. Thanks!

@june128
Copy link
Member Author

june128 commented May 29, 2018

@leios Do you want to delete it or should I just include it in this PR?

@leios
Copy link
Member

leios commented May 29, 2018

I think it's fine to add it to this one

@june128
Copy link
Member Author

june128 commented May 29, 2018

Done.

@leios
Copy link
Member

leios commented May 29, 2018

Should we leave a link to the discord server in the how to contribute chapter?

@june128
Copy link
Member Author

june128 commented May 29, 2018

Why not? The discord server is the place the main AAA discussion happens. It's also nicer to write there about something, that would otherwise spam a PR. Like a discussion about a detail, etc.
Aside from that, it doesn't hurt to have more people on Discord. It shouldn't be a requirement of course, but it's a good option.

@leios
Copy link
Member

leios commented May 29, 2018

Alright, i'll add that in when I get home tonight.

@june128 june128 changed the title Fix links to not point to the old repository anymore. Fix links to not point to the old repository anymore and remove a file that shouldn't be here. May 29, 2018
leios and others added 2 commits May 30, 2018 06:32
Copy link
Member

@leios leios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Necessary changes that I overlooked. Thanks for the catch!

@leios leios merged commit 430f3a1 into algorithm-archivists:master May 29, 2018
@june128 june128 deleted the fixLinksPR branch May 29, 2018 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chapter Edit This changes the archive's chapters. (md files are edited.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants