Skip to content

Add euclidean algorithm implementation for Go #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 29, 2018
Merged

Add euclidean algorithm implementation for Go #160

merged 3 commits into from
Jun 29, 2018

Conversation

chin123
Copy link
Contributor

@chin123 chin123 commented Jun 29, 2018

Run with go run euclidean.go

@zsparal zsparal self-requested a review June 29, 2018 10:41
zsparal
zsparal suggested changes Jun 29, 2018
View reviewed changes
Copy link
Contributor

@zsparal zsparal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add Go to the other two code examples in the chapter (one for the modulus implementation, one for the full example). Other than that, the implementation looks good.

@chin123
Copy link
Contributor Author

chin123 commented Jun 29, 2018

@Gustorn Thanks, fixed now!

@zsparal zsparal merged commit 9595329 into algorithm-archivists:master Jun 29, 2018
@chin123 chin123 deleted the go-euclidean branch June 29, 2018 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zsparal zsparal zsparal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chin123 @zsparal