Add D implementation of monte carlo #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gathros
added
the
Implementation
zsparal
suggested changes
Jun 29, 2018
| import std.typecons : tuple; | ||
|
|
||
| auto rnd = Random(unpredictableSeed); | ||
| return generate(() => tuple!("x", "y")(rnd.uniform01, rnd.uniform01)) |
There was a problem hiding this comment.
I think we should make this part a little more explicit, something like:
auto radius = 1.0;
auto piCount = generate(() => tuple!("x", "y")(rnd.uniform01, rnd.uniform01))
.take(n)
.count!(a => inCircle(a.x, a.y, radius));
return 4.0 * piCount / (n * radius * radius);I definitely think radius should be a variable just or clarity's sake and with that change, jamming the return value into one expression seems a bit over the top.
There was a problem hiding this comment.
I can do the return bit, but its worth noting that the Julia code is being refactored to remove the radius variable entirely. I think that would be better.
There was a problem hiding this comment.
Removing radius also works but I'd still introduce the separate variable for piCount.
zsparal
approved these changes
Jun 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Its a fairly straight forward implementation. Simply run with
rdmd monte_carlo.d