add Go implementation of monte carlo #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsparal
suggested changes
Jun 29, 2018
| } | ||
| } | ||
|
|
||
| var estimate float64 |
There was a problem hiding this comment.
Why this instead of estimate := 4.0 * float64(count) / float64(samples)?
There was a problem hiding this comment.
that was an oversight because the code was slightly different before :) Fixed now
| ) | ||
|
|
||
| func inCircle(x, y float64) bool { | ||
| if x*x+y*y < 1.0 { // the radius of an unit circle is 1.0 |
There was a problem hiding this comment.
This is a pet peeve of mine, you can just do: return x*x+y*y < 1.0
There was a problem hiding this comment.
🤦♂️ don't know why i did that, thanks for mentioning! Fixed now.
zsparal
approved these changes
Jun 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It assumes that we are taking a unit circle, so it takes a radius of 1.0