Skip to content

Removed unnessesary temp variable #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 29, 2018
Merged

Removed unnessesary temp variable #168

merged 2 commits into from
Jun 29, 2018

Conversation

aquacash5
Copy link
Contributor

This is a very minor change, but it is a little more pythonic

@june128 june128 added the Implementation Edit This provides an edit to an algorithm implementation. (Code and maybe md files are edited.) label Jun 29, 2018
zsparal
zsparal suggested changes Jun 29, 2018
View reviewed changes
Copy link
Contributor

@zsparal zsparal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this changes the length of the function (in lines) you should also update the code blocks in the respective chapters. Otherwise it's a nice change

@aquacash5
Copy link
Contributor Author

This should do the trick for the documentation.

@zsparal zsparal merged commit 98a2fac into algorithm-archivists:master Jun 29, 2018
@zsparal
Copy link
Contributor

zsparal commented Jun 29, 2018

Thanks for the contribution :)

@jiegillet jiegillet mentioned this pull request Jul 1, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zsparal zsparal zsparal approved these changes

Assignees
No one assigned
Labels
Implementation Edit This provides an edit to an algorithm implementation. (Code and maybe md files are edited.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aquacash5 @zsparal @june128