Skip to content

Add Huffman encoding example in x86-64 assembly #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 6, 2018

Conversation

zsparal
Copy link
Contributor

@zsparal zsparal commented Oct 4, 2018

No description provided.

@Gathros Gathros self-assigned this Oct 4, 2018
@Gathros Gathros added Implementation This provides an implementation for an algorithm. (Code and maybe md files are edited.) Hacktoberfest The label for all Hacktoberfest related things! labels Oct 4, 2018
Copy link
Contributor

@Gathros Gathros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great. Just one issue why have the code be in binary why not in just having it in string for like in C.

@@ -77,6 +77,8 @@ Whether you use a stack or straight-up recursion also depends on the language, b
[import, lang:"javascript"](code/javascript/huffman.js)
{% sample lang="java" %}
[import, lang:"java"](code/java/huffman.java)
{% sample lang="x64" %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be "asm-x64".

@Gathros Gathros merged commit 035c4c4 into algorithm-archivists:master Oct 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest The label for all Hacktoberfest related things! Implementation This provides an implementation for an algorithm. (Code and maybe md files are edited.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants