Added brainfuck code and explanation for Euclidean Algorithm #463

Ariana1729 · 2018-10-06T14:49:27Z

Just so that multiple algos and langs dont get merged, there's another PR

Ariana1729 · 2018-10-06T15:16:44Z

ok umm not quite sure how to fix the conflicts tbh ill try again maybe like tmr?

leios · 2018-10-06T22:34:05Z

I'll fix the conflicts once the code is reviewed. These are easy ones to fix on my end. I am still trying to wrap my head around BF, though. I want to do these reviews soon!

leios · 2018-10-11T21:32:54Z

I think @Trashtalk217 did a decent BF review last time. Can he also do this review?

Trashtalk217

Since this review is going to take a while, I'm not done, I just wanted to give you something so there is no complete radio silence.

Trashtalk217 · 2018-10-22T09:59:00Z

book.json

+        },
+        {
+          "lang": "bf",
+          "name": "brainfuck"


I think we already have brainfuck in book.jason, put that can easily be fixed by resolving the conflict later.

Trashtalk217 · 2018-10-22T10:00:04Z

book.json

+        },
+        {
+          "lang": "bf",
+          "name": "Brainfuck"


I think we already have brainfuck in book.jason, but a conflict like this can easily be resolved.

Trashtalk217 · 2018-10-22T10:00:44Z

book.json

+        },
+        {
+          "lang": "bf",
+          "name": "Brainfuck"


I think we already have brainfuck in book.jason, but a conflict like this can easily be resolved.

Ignore this, Its double

Trashtalk217 · 2018-10-28T21:09:51Z

contents/euclidean_algorithm/code/brainfuck/euclidean_sub.bf

@@ -0,0 +1,2 @@
+,>,>>>+[[-]<<<<[->>>+<<<]>[->>>+<<<]>>[-<+<<+>>>]>[-<+<<+>>>]<<[->->[-]+<[>-]>[->>]<<<]>[>]<[<<[-]>>[-<<+>>>+<]]<[<<[-]>>[-<<+>>>>+<<]]>>>[-]+>[-]<<[>-]>[<<<<.>>>>->>]<<]


I'd first like to note it's really hard commenting on a onliner but I'll do my best: the second [-] is unnecessary, I've never seen it called.

Trashtalk217 · 2018-10-30T13:10:24Z

contents/euclidean_algorithm/code/brainfuck/euclidean_sub.bf

@@ -0,0 +1,2 @@
+,>,>>>+[[-]<<<<[->>>+<<<]>[->>>+<<<]>>[-<+<<+>>>]>[-<+<<+>>>]<<[->->[-]+<[>-]>[->>]<<<]>[>]<[<<[-]>>[-<<+>>>+<]]<[<<[-]>>[-<<+>>>>+<<]]>>>[-]+>[-]<<[>-]>[<<<<.>>>>->>]<<]


I'm just going to leave a nice indented version down below, so I can accuratly point some things out.

,>, >>>+ [ [-] <<<< [->>>+<<<] > [->>>+<<<] >> [-<+<<+>>>] > [-<+<<+>>>] << [ ->-> **[-]** +< [>-] > [->>] <<< ] > [>] < [ << [-] >> [-<<+>>>+<] ] < [ << [-] >> [-<<+>>>>+<<] ] >>> **[-]** + **>[-]<** < [>-] > [<<<<.>>>>->>] << ]

The parts I surrounded with ** I found to be unneeded. And I have been able to leave them away without much issue.

Trashtalk217 · 2018-10-30T14:02:04Z

contents/euclidean_algorithm/code/brainfuck/euclidean_mod.bf

@@ -0,0 +1 @@
+>,>,[<[>->+<[>]>[<+>-]<<[<]>-]>[-<+>]>[-<+<+>>]<]<.


I'm generally happy with this code, it did take some checking to find out that the [>->+<[>]>[<+>-]<<[<]>-] part, you got from here was in the public domain, but I eventually found this, so it's fine.

Ariana1729 · 2018-10-30T19:45:01Z

oh yes hi, updated the code&updated this branch

Trashtalk217 · 2018-10-31T20:13:27Z

contents/euclidean_algorithm/euclidean_algorithm.md

@@ -209,6 +213,114 @@ and modulo method:
 [import, lang="LOLCODE"](code/lolcode/euclid.lol)
 {% sample lang="bash" %}
 [import, lang="bash"](code/bash/euclid.bash)
+{% sample lang="bf" %}
+#### Subtraction varient
+##### Code


I'm happy with the code at this point. The code is as slim as it can be without having to redo the fundemantals. This leaves me with one final question, and that one is of style: What is your justification for writing your code as a one-liner and then a explanation in the md-file? We already have a brainfuck bubble sort and it is quiet different -> here

iirc there was a discussion in the discord chat about if to combine the explanation and code, and we agreed on removing all comments in the code to make it more 'brainfuck', i see if i can find that chat

#407 (comment)
So basically there was a discussion, also on discord iirc? and was like agreed to have the brainfuck code to have comments striped

I used the "source code" then commented version with my whitespace submission. I think it's best this way. Brainfuck is a joke language and the joke is more effective without comments, but then after you see the source code you want to know more and that's when the comments are nice.

I just find the format we already have for the bubble sort bf more easy to read and review and it also keeps documentation and code in the same place, which I prefer. And when this PR is added we'll lose some concistency between chapters. Still, having a style guide for brainfuck code seams a bit ridiculous and if this is the way some other people already agreed on, I'm fine with that. In that case I will start reviewing the explanation part.

wait so do we want like
Brainfuck is a joke language and the joke is more effective without comments & reformat prev code
or like same as previous pr

@jiegillet prefers the first and I prefer the latter. I've asked Leios what he thinks of it, he'll look at it later.

I understand that the in-text code should be more BF-like; however, a commented version is also necessary (if possible). Both this chapter and bubble sort provide an adequate solution; however, I would argue that the bubble sort seems much easier to read when the two chapters are put side-by-side.

I think this ultimately boils down to a number of factors:

a single line of BF code does not actually fit on the page when rendering online

the explanation provided for this chapter is a bit hard to follow. Somehow the commented Bubble sort implementation is easier, even though it has less detail.

With other esoteric languages (like whitespace), the code was displayed as it would be seen in actually whitespace code, and then a heavily commented / modified version was put underneath. I think this is also a fine solution, but if we do that we need to make sure that the BF code actually fits into the AAA codebox.

I think the best solution is just to provide a heavily commented BF code sample with the explanation in-built. If that's not possible, the explanation at the end of the chapter is still useful, but should be rewritten (which I can help with). Sorry for all the extra work.

Oh I just rmbed why the commented code wasnt in the file
All the .,[]+- was screwing up the code

was kinda busy with like music and school so was afk the whole of nov:/ Not quite sure how well this explanation is but at least its slightly better

Ariana1729 · 2018-12-04T15:25:01Z

was kinda busy with like music and school so was afk the whole of nov:/
Not quite sure how well this explanation is but at least its slightly better

benchislett · 2019-05-25T21:26:11Z

contents/euclidean_algorithm/euclidean_algorithm.md

+**Here, we subtract 1 from cell 2 from 3 until one of them hits 0, the other cell would be |a-b|**
+```
+<<
+[->- subtracts a from b, assuming a>b


Wouldn't a>b actually affect the code execution here?

yeah that’s one of the reasons why I didn’t comment in the actual bf code, cuz .,<> are all affecting execution

Gathros added Implementation This provides an implementation for an algorithm. (Code and maybe md files are edited.) Hacktoberfest The label for all Hacktoberfest related things! labels Oct 6, 2018

Ariana1729 closed this Oct 11, 2018

Ariana1729 force-pushed the euclidalgo_bf branch from 0c91e8f to e8fdf02 Compare October 11, 2018 16:44

Ariana1729 reopened this Oct 11, 2018

Trashtalk217 requested changes Oct 28, 2018

View reviewed changes

Trashtalk217 reviewed Oct 30, 2018

View reviewed changes

Added euclid algo in bf

7372cd9

Ariana1729 force-pushed the euclidalgo_bf branch from 3cf8c21 to 7372cd9 Compare October 30, 2018 16:00

Trashtalk217 reviewed Oct 31, 2018

View reviewed changes

remove random newline

a5e440d

leios changed the title ~~Added brainfuck code and explanation~~ Added brainfuck code and explanation for Euclidean Algorithm Nov 10, 2018

Slightly better explanation for the subtraction code?

1fd481e

was kinda busy with like music and school so was afk the whole of nov:/ Not quite sure how well this explanation is but at least its slightly better

benchislett reviewed May 25, 2019

View reviewed changes

leios added the lang: brainfuck Brainfuck programming language label Aug 28, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added brainfuck code and explanation for Euclidean Algorithm #463

Added brainfuck code and explanation for Euclidean Algorithm #463

Ariana1729 commented Oct 6, 2018

Ariana1729 commented Oct 6, 2018

leios commented Oct 6, 2018 •

edited

Loading

leios commented Oct 11, 2018

Trashtalk217 left a comment

Trashtalk217 Oct 22, 2018

Trashtalk217 Oct 22, 2018

Trashtalk217 Oct 22, 2018

Trashtalk217 Oct 28, 2018

Trashtalk217 Oct 28, 2018

Trashtalk217 Oct 30, 2018 •

edited

Loading

Trashtalk217 Oct 30, 2018

Ariana1729 commented Oct 30, 2018

Trashtalk217 Oct 31, 2018

Ariana1729 Nov 1, 2018

Ariana1729 Nov 1, 2018 •

edited

Loading

jiegillet Nov 1, 2018

Trashtalk217 Nov 1, 2018

Ariana1729 Nov 10, 2018

Trashtalk217 Nov 10, 2018

leios Nov 10, 2018

Ariana1729 Dec 4, 2018

Ariana1729 commented Dec 4, 2018

benchislett May 25, 2019

Ariana1729 May 27, 2019

		@@ -0,0 +1,2 @@
		,>,>>>+[[-]<<<<[->>>+<<<]>[->>>+<<<]>>[-<+<<+>>>]>[-<+<<+>>>]<<[->->[-]+<[>-]>[->>]<<<]>[>]<[<<[-]>>[-<<+>>>+<]]<[<<[-]>>[-<<+>>>>+<<]]>>>[-]+>[-]<<[>-]>[<<<<.>>>>->>]<<]

		@@ -0,0 +1 @@
		>,>,[<[>->+<[>]>[<+>-]<<[<]>-]>[-<+>]>[-<+<+>>]<]<.

Added brainfuck code and explanation for Euclidean Algorithm #463

Are you sure you want to change the base?

Added brainfuck code and explanation for Euclidean Algorithm #463

Conversation

Ariana1729 commented Oct 6, 2018

Ariana1729 commented Oct 6, 2018

leios commented Oct 6, 2018 • edited Loading

leios commented Oct 11, 2018

Trashtalk217 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Trashtalk217 Oct 30, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Ariana1729 commented Oct 30, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Ariana1729 Nov 1, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Ariana1729 commented Dec 4, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

leios commented Oct 6, 2018 •

edited

Loading

Trashtalk217 Oct 30, 2018 •

edited

Loading

Ariana1729 Nov 1, 2018 •

edited

Loading