Adding javascript and c to euclidean algorithm #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Oh ok and I made it in the live stream. |
|
Haha, fair enough! Thanks so much for submitting / the support! You rock! |
Gathros
pushed a commit
that referenced
this pull request
Aug 4, 2018
Adding `dfs_recursive_inorder_btree` to rust
june128
added a commit
that referenced
this pull request
Nov 16, 2018
This is a combination of 5 commits. This is the 1st commit message: Add Tree Traversal in Emojicode This is the commit message #2: Remove unnecessary 🤜🤛. This was suggested by thbwd: "No need to wrap 🤜children_count🤛 into 🤜🤛actually." (https://github.com/algorithm-archivists/algorithm-archive/pull/ 471#discussion_r223291032) This is the commit message #3: Extract shared logic into a method. This was suggested by thbwd: "This is shared logic. I’d recommend you extract it into a method." (https://github.com/algorithm-archivists/algorithm-archive/pull/ 471#discussion_r223291140) This is the commit message #4: Use documentation comments. This was suggested by thbwd: "Shouldn’t these be documentation comments? https://www.emojicode.org/ docs/reference/documentation.html" (https://github.com/algorithm-archivists/algorithm-archive/pull/ 471#discussion_r223291281) This is the commit message #5: Add error as a potential return value for DFS RI Binary To be able to return an error and to apply suggestion by thbwd (https://github.com/algorithm-archivists/algorithm-archive/pull/ 471#discussion_r223597592) the following changes were made: - Declare an enum to hold the error value. - Rewrite the Depth-First Search Recursive Inorder Binary method to return an optional holding the enum and adjust the returns according to that. - Call the rewritten method and check, if the returned optional holds error. If it does: Print out the error message defined in the enum. Signed-off-by: Julian Schacher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
why did you remove euclid_rec