Added cooley tukey to js #520
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
june128
added
Hacktoberfest
|
Only that file had ';'s in it so just removed those for consistency |
|
I don't think we should add libraries to the AAA like that. I'm not saying that we can't use them. I'm just saying that we shouldn't add the files. I'd suggest adding a comment to the top of the files saying something like |
|
This is not a proper review, but your indentation is all over the place. |
|
Hey @Ariana1729, we screwed up. We should have looked at this PR before merging the newer FFT implementation in js (#599). As it stands now, we have an implementation in the algorithms archive, so I will close this PR. We really appreciate the submission and I personally apologize for the mix up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should I use complex or complex.min, complex.js is easier to read but complex.min.js is smaller
Source: https://github.com/infusion/Complex.js