Tree traversal implementation scala #531
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenpower
force-pushed
the
tree-traversal-implementation-scala
branch
2 times, most recently
from
4ed892e to
570df70
Compare
leios
added
Implementation
jiegillet
previously requested changes
Nov 10, 2018
kenpower
added a commit
to kenpower/algorithm-archive
that referenced
this pull request
Mar 21, 2021
kenpower
force-pushed
the
tree-traversal-implementation-scala
branch
from
3793bc6 to
336ef50
Compare
|
Sorry, it's been a while since the PR started. It kind of fell off my radar for a bit. Hope you can look at it again. |
leios
reviewed
Dec 28, 2021
There was a problem hiding this comment.
Small changes and I think it is good to merge since all og @jiegillet's issues have been resolved.
Super sorry for the delay with all of this
| @@ -93,6 +95,8 @@ Because of this, the most straightforward way to traverse the tree might be recu | |||
| [import:31-45, lang:"matlab"](code/matlab/tree.m) | |||
| {% sample lang="coco" %} | |||
| [import:5-9, lang:"coconut"](code/coconut/tree_traversal.coco) | |||
| {% sample lang="scala" %} | |||
| [import:26-34, lang:"scala"](code/scala/tree.scala) | |||
There was a problem hiding this comment.
Suggested change
| [import:26-34, lang:"scala"](code/scala/tree.scala) | |
| [import:27-34, lang:"scala"](code/scala/tree.scala) |
| @@ -148,6 +152,9 @@ Now, in this case the first element searched through is still the root of the tr | |||
| {% sample lang="m" %} | |||
| [import:47-62, lang:"matlab"](code/matlab/tree.m) | |||
| {% sample lang="coco" %} | |||
| [import:11-15, lang:="coconut"](codo/coconut/tree_traversal.coco) | |||
| {% sample lang="scala" %} | |||
| [import:36-43, lang:"scala"](code/scala/tree.scala) | |||
| [import:11-15, lang:="coconut"](code/coconut/tree_traversal.coco) | |||
There was a problem hiding this comment.
Suggested change
| [import:11-15, lang:="coconut"](code/coconut/tree_traversal.coco) |
Amaras
dismissed
jiegillet’s stale review
Changes were made, this review is (probably) no longer valid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.