-
-
Notifications
You must be signed in to change notification settings - Fork 359
Added Bubblesort in Chip-8 assembly #547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This code in and of itself is a runnable example, which displays an array of 12 random bytes before being sorted, and after https://massung.github.io/CHIP-8/ tested using this emulator
I have no idea how to review this one... Maybe @Gathros ? |
I'll take a look at it, but I can't promise anything. |
@leios what does a review entail exactly |
@theinventor13 It should be quick, then. The review is just a check to make sure the code functions and follows appropriate style guidelines; however, in this case, we are probably more concerned about functionality than style. |
@leios ok cool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code itself is super.
Could you also add the parts of your file to the markdown now so it can be displayed on the website as well?
More info on how to do that can be found here: https://github.com/algorithm-archivists/algorithm-archive/wiki/How-to-Contribute#step-33---adding-code-to-your-aaa-repo |
ok ill do it later today |
dba408f
to
1c9beaa
Compare
i hate git
another shitty typo
yes it works now 👍 |
This code in and of itself is a runnable example, which displays an array of 12 random bytes before being sorted, and after
https://massung.github.io/CHIP-8/ tested using this emulator