Skip to content

Added Bubblesort in Chip-8 assembly #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 24, 2018

Conversation

theinventor13
Copy link
Contributor

This code in and of itself is a runnable example, which displays an array of 12 random bytes before being sorted, and after
https://massung.github.io/CHIP-8/ tested using this emulator

This code in and of itself is a runnable example, which displays an array of 12 random bytes before being sorted, and after
https://massung.github.io/CHIP-8/ tested using this emulator
@theinventor13 theinventor13 changed the title Bubblesort in Chip-8 assembly Bubblesort in Chip-8 assembly #Implementation Nov 30, 2018
@theinventor13 theinventor13 changed the title Bubblesort in Chip-8 assembly #Implementation Bubblesort in Chip-8 assembly Nov 30, 2018
@theinventor13 theinventor13 changed the title Bubblesort in Chip-8 assembly Added Bubblesort in Chip-8 assembly Nov 30, 2018
@leios leios added the Implementation This provides an implementation for an algorithm. (Code and maybe md files are edited.) label Nov 30, 2018
@leios
Copy link
Member

leios commented Dec 23, 2018

I have no idea how to review this one... Maybe @Gathros ?

@Liikt
Copy link

Liikt commented Dec 23, 2018

I'll take a look at it, but I can't promise anything.

@Liikt Liikt self-assigned this Dec 23, 2018
@Liikt Liikt self-requested a review December 23, 2018 23:56
@theinventor13
Copy link
Contributor Author

@leios what does a review entail exactly
there are quite a few references for chip 8 syntax and functionality, i included a link to a relatively complete emulator, and the code includes a self-test

@leios
Copy link
Member

leios commented Dec 24, 2018

@theinventor13 It should be quick, then. The review is just a check to make sure the code functions and follows appropriate style guidelines; however, in this case, we are probably more concerned about functionality than style.

@theinventor13
Copy link
Contributor Author

@leios ok cool

Copy link

@Liikt Liikt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code itself is super.

Could you also add the parts of your file to the markdown now so it can be displayed on the website as well?

@leios
Copy link
Member

leios commented Dec 24, 2018

@theinventor13
Copy link
Contributor Author

ok ill do it later today

@Liikt
Copy link

Liikt commented Dec 24, 2018

yes it works now 👍

@Liikt Liikt merged commit 8578823 into algorithm-archivists:master Dec 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Implementation This provides an implementation for an algorithm. (Code and maybe md files are edited.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants