Skip to content

Adding videos to chapters #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 18, 2018

Conversation

leios
Copy link
Member

@leios leios commented Dec 16, 2018

This PR adds a video to each chapter with a video associated with it. I understand if people are against this.

@jiegillet
Copy link
Member

I think it's a great idea. Synergy!

@Gathros Gathros added the Chapter Edit This changes the archive's chapters. (md files are edited.) label Dec 17, 2018
@leios
Copy link
Member Author

leios commented Dec 18, 2018

Cool. I think most people are generally in favour of the idea, so I'll force merge it later (unless someone wants to approve it first)

Copy link
Member

@june128 june128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
The requested changes are just regarding additional lines, that shouldn't be there for consistency sake.

@leios leios merged commit fb4f592 into algorithm-archivists:master Dec 18, 2018
@leios leios deleted the youtube_references branch December 23, 2018 23:14
theinventor13 added a commit to theinventor13/algorithm-archive that referenced this pull request Dec 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chapter Edit This changes the archive's chapters. (md files are edited.) General
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants