Skip to content

Java filename changes for Verlet / bogosort / bubblesort #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 23, 2019

Conversation

berquist
Copy link
Member

I was setting up IntelliJ to work with Kotlin, and I had to make some changes to get it to stop complaining about these Java implementations.

Most notable is that public classes should be in their own files, hence the new VerletValues.java.

There is still a complaint about VerletValues existing in both Kotlin and Java (because they both compile to a JVM class of the same name), but that's safe to ignore.

@june128 june128 added the Implementation Edit This provides an edit to an algorithm implementation. (Code and maybe md files are edited.) label Jan 19, 2019
Copy link
Member

@leios leios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. If this helps out with the development, then it's worth it.

@leios leios merged commit 37e2607 into algorithm-archivists:master Jan 23, 2019
@berquist berquist deleted the java-cleanup branch February 2, 2019 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Implementation Edit This provides an edit to an algorithm implementation. (Code and maybe md files are edited.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants