Skip to content

Variable name change #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 2, 2019
Merged

Variable name change #586

merged 1 commit into from
Feb 2, 2019

Conversation

tsik1
Copy link
Contributor

@tsik1 tsik1 commented Jan 31, 2019

The current variable name 'number' is a little generic and it doesn't really point to an array. It may confuse a beginner

@june128 june128 added the Implementation Edit This provides an edit to an algorithm implementation. (Code and maybe md files are edited.) label Jan 31, 2019
berquist
berquist approved these changes Feb 2, 2019
View reviewed changes
Copy link
Member

@berquist berquist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. Thank you!

@berquist berquist merged commit 2f0b7af into algorithm-archivists:master Feb 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berquist berquist berquist approved these changes

Assignees
No one assigned
Labels
Implementation Edit This provides an edit to an algorithm implementation. (Code and maybe md files are edited.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tsik1 @berquist @june128