Tree Traversal in Ruby

[tarunvelli]

No description provided.

[ntindle]

[lang: ruby]

[lazyprop]

Sorry it took so long to get to this.

One problem I notice is that you're not executing dfs_inorder anywhere. Also, there should be proper labels printed before each test case.

In accordance with #857 the final output should be identical to this:

[#]
Recursive DFS:
2 1 0 0 0 1 0 0 0 1 0 0 0
[#]
Recursive Postorder DFS:
0 0 0 1 0 0 0 1 0 0 0 1 2
[#]
Stack-based DFS:
2 1 0 0 0 1 0 0 0 1 0 0 0
[#]
Queue-based BFS:
2 1 1 1 0 0 0 0 0 0 0 0 0
[#]
Recursive Inorder DFS for Binary Tree:
0 1 0 2 0 1 0 3 0 1 0 2 0 1 0

Other than that, the code looks clean to me. I am not a Ruby dev, so someone else with more experience should probably take a look this.

[Amaras]

Right, I just merged a PR to the master branch. Please resolve conflicts before we can consider merging.

Thank you for your reactivity after this long, though 😃

[tarunvelli]

Resolved the merge conflicts
It was nice to get a notification from this repo after such a long time, always happy to contribute 😄

[tarunvelli]

@Amaras @lazyprop I've rebased with the latest master

[leios]

The reason these PR's take so long is that we don't have people who know the language (in this case ruby). On my end, it looks clean, so maybe I can just merge it as is?