Skip to content

Added approximate counting in Rust #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 8, 2021
Merged

Added approximate counting in Rust #900

merged 7 commits into from
Dec 8, 2021

Conversation

PaddyKe
Copy link
Contributor

@PaddyKe PaddyKe commented Oct 23, 2021

No description provided.

@PaddyKe PaddyKe changed the title Added Approximate counting in Rust Added approximate counting in Rust Oct 23, 2021
@Amaras
Copy link
Member

Amaras commented Oct 23, 2021

When providing a Rust implementation, we've decided that we need to have a Cargo.toml file to help with and simplify compilation.

@Amaras Amaras added Implementation This provides an implementation for an algorithm. (Code and maybe md files are edited.) lang: rust Rust programming language labels Oct 23, 2021
Amaras
Amaras reviewed Oct 23, 2021
View reviewed changes
Copy link
Member

@Amaras Amaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, the code is clean, but I don't know Rust enough to give a correct review. I quite like it, though.

ShadowMitia
ShadowMitia approved these changes Dec 8, 2021
View reviewed changes
Copy link
Contributor

@ShadowMitia ShadowMitia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks fine.

@ShadowMitia ShadowMitia merged commit 508cfb5 into algorithm-archivists:main Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amaras Amaras Amaras left review comments

@ShadowMitia ShadowMitia ShadowMitia approved these changes

Assignees
No one assigned
Labels
Implementation This provides an implementation for an algorithm. (Code and maybe md files are edited.) lang: rust Rust programming language
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PaddyKe @Amaras @ShadowMitia