Fix warnings and remove VLA on C++ Thomas algorithm #932
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes warnings generated by the code, and removes a variable length array which is not legal in C++ (it's a compiler extension, which most of them do have, but is not strictly speaking C++).
I've also
const
ified and added references where I thought it would be best applicable.The only part I'm not sure of is :
and my use of the
static_cast
. size is astd::size_t
and we can't just havei
be one too (or anyunsigned
) because of overflow issues which would break the condition. I'm not sure what's the best thing to do in this scenario.My guess is it's generally fine, and you should only be worried on very large arrays. Which is not the point here.