Updated tree traversal chapter #979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made it more pythonic and compact. Usage of temp variable wasn't necessary nor was the loop through children or the appending of the root node to the stack.
Closed
Amaras
added
Implementation Edit
More compact and pythonic
Amaras
reviewed
Dec 27, 2021
There was a problem hiding this comment.
Thank you for your first PR in the AAA.
I agree this chapter needed a bit of a better implementation, which you provided.
However, since you changed the number of lines in some functions, you will need to modify the line numbers in contents/tree_traversal/tree_traversal.md.
I'll wait for you to do that before approving.
Fixed line numbers to match new dfs_stack and bfs_queue implementation
Replaced iadd with extend in dfs_stack and bfs_queue
Amaras
approved these changes
Dec 27, 2021
|
Alright, there seems to be a GH Actions problem, so we'll see when the incident is resolved, sorry for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made it more pythonic and compact. Usage of temp variable wasn't necessary nor was the loop through children or the appending of the root node to the stack.