Possible memory leak

[ivandotv]

Currently I'm using sortable on vertical list, so rows can be moved up and down. And also the rows themselves have sortable enabled so elements inside them can be moved horizontally ( nested ng-repeat).

There are two routes in my application when the user moves from the route a the list is destroyed. When he moves back , the list is recreated and all ng-repeats and sortable are recreated.

I'm using angular ui router for navigation.

The problem is that I'm getting a lot of detached DOM nodes, destroy events by angular are being called, and I'm cleaning up everything that I've done on those ng-repeat elements. However looking at the sortable code I don't see $destroy functionality?

[thgreasi]

Oooops! I'm going to investigate it as soon as possible, but I think it's going to be merged with v0.13x.
Can you help me to fast-start by providing a pen?
Thanks.

[ivandotv]

It's part of a larger codebase , and there are a lot of moving parts, but I'll see if I can make a plunker later today.

P.S there is a destroy method for Jquery UI sortable, I think you should at least call that when the element is removed from the DOM. I've done that but memory leak is still present, so now I'm investigating ui router and nested ng-repeat

[thgreasi]

I just created a new branch to test things out.

[thgreasi]

@ikixxx a good example code to test this out should be the Tree with dynamic template example of the README file.

[ivandotv]

I'll take a look as soon as I get some free time.

[thgreasi]

@ikixxx I just did some testing and could not spot any leak.
Used timeline, heap snapshot comparisons and heap allocations recording on chrome beta.
I'm closing this for now, please reopen if you find something.

[ivandotv]

ok, thanks.

[thgreasi]

@ikixxx does v1.12.10 release (that merges PR #244) help with your problem?

[ivandotv]

It does, but I still have some memory leaks, however they may not be associated with sortable
I'll investigate it further.

[thgreasi]

It does

Glad to hear it.