Skip to content

Have NodePackageInstallTask use project directory if no directory specified #21680

@mcalmus

Description

@mcalmus

🚀 Feature request

Command (mark with an x)

  • new
  • build
  • serve
  • test
  • e2e
  • generate
  • add
  • update
  • lint
  • extract-i18n
  • run
  • config
  • help
  • version
  • doc

Description

A clear and concise description of the problem or missing capability...

NodePackageInstallTask is frequently used by add tasks such as ng-add in @angular/material. If a schematic like this is called from a custom ng-new schematic using externalSchematic the install fails because it is run from some non-project directory rather than from inside the newly created project directory.

Describe the solution you'd like

If you have a solution in mind, please describe it.

Since schematics knows the location of package.json it should by default run NodePackageInstallTask from that same directory rather than using the working directory.

This would unfortunately qualify as a "breaking" change so a configuration option might be necessary to allow for the "old" (current) behavior once this change is made.

Describe alternatives you've considered

Have you considered any alternative solutions or workarounds?

The only work-around I've been able to do is essentially replicating the behaviors of third-party schematic "add" tasks within my custom schematic and then running install after the fact which is less than ideal.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions