Skip to content

docs: ng add configures project in cwd #15377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 21, 2019
Merged

docs: ng add configures project in cwd #15377

merged 2 commits into from
Aug 21, 2019

Conversation

jbogarthyde
Copy link
Contributor

@jbogarthyde jbogarthyde commented Aug 19, 2019 •
edited by alan-agius4
Loading

Updates doc for ng add as requested in Issue #15348

Closes #15348

@jbogarthyde jbogarthyde added effort1: easy (hours) P5 The team acknowledges the request but does not plan to address it, it remains open for discussion area: docs Related to the documentation freq1: low Only reported by a handful of users who observe it rarely severity1: confusing area: @angular/cli target: patch This PR is targeted for the next patch release labels Aug 19, 2019
alan-agius4
alan-agius4 reviewed Aug 20, 2019
View reviewed changes
alan-agius4
alan-agius4 reviewed Aug 20, 2019
View reviewed changes
alan-agius4
alan-agius4 approved these changes Aug 21, 2019
View reviewed changes
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyliau kyliau merged commit 08d7d02 into angular:master Aug 21, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alan-agius4 alan-agius4 alan-agius4 approved these changes

Assignees

@jbogarthyde jbogarthyde

Labels
area: @angular/cli area: docs Related to the documentation effort1: easy (hours) freq1: low Only reported by a handful of users who observe it rarely P5 The team acknowledges the request but does not plan to address it, it remains open for discussion severity1: confusing target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs(ng-add): docs don't mention that the library will be installed in the project of the CWD
4 participants
@jbogarthyde @alan-agius4 @kyliau @googlebot