Skip to content

fix(@angular/cli): use JIT by default with ng5 #8267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2017
Merged

fix(@angular/cli): use JIT by default with ng5 #8267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/@angular/cli/models/webpack-config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ export class NgCliWebpackConfig<T extends BuildOptions = BuildOptions> {
sourcemaps: true,
extractCss: false,
namedChunks: true,
aot: AngularCompilerPlugin.isSupported(),
aot: false,
buildOptimizer: false
},
production: {
Expand Down
4 changes: 2 additions & 2 deletions tests/e2e/tests/i18n/build-locale.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@ export default function () {
// These tests should be moved to the default when we use ng5 in new projects.
return Promise.resolve()
// tests for register_locale_data transformer
.then(() => ng('build', '--locale=fr'))
.then(() => ng('build', '--aot', '--locale=fr'))
.then(() => expectFileToMatch('dist/main.bundle.js', /registerLocaleData/))
.then(() => expectFileToMatch('dist/main.bundle.js', /angular_common_locales_fr/))
.then(() => rimraf('dist'))
.then(() => expectToFail(() => ng('build', '--locale=no-locale')))
.then(() => expectToFail(() => ng('build', '--aot', '--locale=no-locale')))
}