Incorrect Croatian translations

[Victa]

The generated Croatian locale isn't correct. Two last letters are misspelled in all months.

However, the sources (Google Closure) are correct

angular.js/i18n/closure/datetimeSymbolsExt.js

Line 11328 in d3b1f50

'lipanj', 'srpanj', 'kolovoz', 'rujan', 'listopad', 'studeni', 'prosinac'],

[caitp]

@chirayuk can this be added to your work on the i18n update?

[thorn0]

I think it's not a bug, it's an inflected form (genitive case) which is required in Croatian dates like in many other Slavic languages. For example, look at the main page of the Croatian Wikipedia. You'll find dates there written like this: "29. studenoga", "1. prosinca". So it's OK for patterns like "d. MMMM", but if you just need to write a standalone name of a month, then yes, this form shouldn't be used, nominative case is needed. And again, it applies to many other Slavic languages: Polish, Ukrainian, etc. Often in date formatting code, this issue is solved by a simple check like:

useGenitive = /(^|[^d])d(?!dd)/.test(pattern);

It checks whether the pattern contains 'd' or 'dd'. This check is that simple even in the .NET base class library, so .NET erroneously uses genitive even when the pattern includes an escaped literal 'd' character:

var d = new DateTime(2014,12,1);
var culture = System.Globalization.CultureInfo.GetCultureInfo("hr");
Console.WriteLine(d.ToString("MMMM", culture)); // "prosinac"
Console.WriteLine(d.ToString("d MMMM", culture)); // "1 prosinca"
Console.WriteLine(d.ToString("\\c MMMM", culture)); // "c prosinac"
Console.WriteLine(d.ToString("\\d MMMM", culture)); // "d prosinca"

[thorn0]

This issue was already raised in #3483. However, it's not true that "The nominative case can be used always, but the genitive case can be used only in some situations". As I've already written, some situations require nominative, and other require genitive.

[lgalfaso]

I think the issue is that there are two ways to write a month, this is when the month is part of a date and when it is stand-alone. This is already defined at the CLDR, but angular does not copy nor adds the pattern support for this.

A PR that adds support for this would be welcome.