Add Setting to enable allOrNothing for ngHref

[cancan101]

See: #10015

[caitp]

@cancan101 I agree with you that it would be nice to have all-or-nothing ng-href support, however, I'm not keen on setting all-or-nothing via a configuration option. (these options make the API more confusing, nobody wants to use them, they aren't declarative, etc etc etc). I would prefer to just have a new directive for it, or else specify the behaviour some other way. Maybe ng-href vs ng-href! or ng-strict-href or something?

we could also just make it the de facto behaviour and introduce a breaking change, but that makes it hard to ship the feature for a few months (it would put it in 1.4).

@petebacondarwin what do you think? --- @cancan101 would you be interested in hacking together an implementation?

[petebacondarwin]

@caitp - This is a crazy idea but what about cooking it into the angular expression, similar to what we do with one-time-binding?

For example we could pick some indicator, perhaps :!. If this appeared in any of the expressions in a binding then we would do an all or nothing. Then the ng-href issue would be solved by:

<a ng-href="a/b/{{:!mustHaveProp}}/index.html">...</a>

[caitp]

I don't think that makes much sense --- That line of thinking is more like "this particular sub-expression is required" (but the ! would not work because it is a valid operator)

[petebacondarwin]

@caitp Are you worried about the particular trigger token or the general concept?
The token can be changed - it was just a random set of chars I got off the top of my head.
The question is whether the concept of indicating a required expression in a set of interpolation bindings is a useful strategy.

[caitp]

@petebacondarwin I think it's a fine idea --- it's just not the same as allOrNothing. It might increase complexity too much to support that, but it seems perfectly useful. I don't think we can really encode an "allOrNothing" flag in the interpolated string itself, though :(

[petebacondarwin]

OK how about an additional all-or-nothing attribute on the a element that
ngHref checks?
On 6 Dec 2014 21:47, "Caitlin Potter" notifications@github.com wrote:

@petebacondarwin https://github.com/petebacondarwin I think it's a fine
idea --- it's just not the same as allOrNothing. It might increase
complexity too much to support that, but it seems perfectly useful. I don't
think we can really encode an "allOrNothing" flag in the interpolated
string itself, though :(

—
Reply to this email directly or view it on GitHub
#10320 (comment)
.

[caitp]

that would be fine I guess, but really verbose

[caitp]

It probably makes more sense to just make it the default behaviour in all cases

[petebacondarwin]

I agree with making it the default - the backward compatible workaround would be to make sure that values are not undefined but null or "" empty strings instead.