Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Rhino compatibility with angular 1.3.8 #10586

Closed
@stefanofornari

Description

@stefanofornari

I am opening another issue regarding Rhino compatibility with angular 1.3.8. The good news is that I managed to get it to work, at least so far, but there are a few tweaks to make. I hope they can be applied to the code base because they are quite basic.

I am attaching two files:

  1. angular-1.3.8.diff[1] contains a few changes to angular.js make it digestible by Rhino
  2. ecma5-adapter.js[2] contains a few functions that I had to create to support some ECMA5 features not available in Rhino.

I am sorry if I can not produce a PR, but I am new to JS development environments and I am not familiar with the build. If a PR is mandatory and you are OK in merging the changes I am proposing I will be happy to take the load to make the PR.

[1] https://drive.google.com/file/d/0BzWVgSXXLzyTbVVyeWdTSjNHWjA/view?usp=sharing
[2] https://drive.google.com/file/d/0BzWVgSXXLzyTWGU3c01jRWZzb00/view?usp=sharing

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions