$http - TypeError: Cannot read property 'protocol' of undefined

[dhoko]

Hi,

Current version: 1.4.6.
There is a bug with $http, if you perform an undefined request (as url) cf Bug demo, the condition in urlIsSameOrigin is false, and it creates an error hard to debug:

TypeError: Cannot read property 'protocol' of undefined
    at urlIsSameOrigin (vendor.min.js:17930)
    at sendReq (vendor.min.js:10507)
    at $get.serverRequest (vendor.min.js:10221)
    at processQueue (vendor.min.js:14678)
    at vendor.min.js:14694
    at Scope.$get.Scope.$eval (vendor.min.js:15922)
    at Scope.$get.Scope.$digest (vendor.min.js:15733)
    at Scope.$get.Scope.$apply (vendor.min.js:16030)
    at done (vendor.min.js:10545)
    at completeRequest (vendor.min.js:10717)

// current
function urlIsSameOrigin(requestUrl) {
  var parsed = (isString(requestUrl)) ? urlResolve(requestUrl) : requestUrl;
  return (parsed.protocol === originUrl.protocol &&
          parsed.host === originUrl.host);
}

// Patch ?
function urlIsSameOrigin(requestUrl) {
  var parsed = (isString(requestUrl) || !requestUrl) ? urlResolve(requestUrl) : requestUrl;
  return (parsed.protocol === originUrl.protocol &&
          parsed.host === originUrl.host);
}

Ex:

var REQUEST_LOCATION_API = urlApp.api('geo.json');
$http.get(REQUEST_LOCATION_API, {cache: true});

If REQUEST_LOCATION_API is undefined it won't works :/ but there is a request for http://localhost/

No PR because I don't know if this patch is correct.

[Narretz]

We should probably catch an empty url before it even gets to that point. And then throw a meaningful error?

[sashless]

This hits $http interceptors and errors there again because supplied error doesnt have a config object because it is a exception and not a $http rejection error

[111999Wlying]

isURLSameOrigin.js?0987:57 Uncaught (in promise) TypeError: Cannot read property 'protocol' of undefined
at isURLSameOrigin (isURLSameOrigin.js?0987:57)
at dispatchXhrRequest (xhr.js?21f6:109)
at Promise ()
at xhrAdapter (xhr.js?21f6:12)
at dispatchRequest (dispatchRequest.js?a2c1:52)