Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix($resource): remove (broken) support for _promise as timeout_ #13393

Closed
@gkalpak

Description

@gkalpak

7170f9d which added support for using a promise as timeout in $resource, introduced a bug (where you had to re-create the resource class after every cancelled request and failing to do so would abort all subsequent calls). See #12657 (comment) for more context.

This has been fixed in v1.5.x with #13210, but we need to also fix it on v1.4.x (#13210 is not suitable for backporting to v1.4.x since it adds a new feature and changes the behaviour of $resource to some extent).

As discussed in #13210 (comment), for v1.4.x we need to:

  • Revert 7170f9d.
  • Update the docs to explain that promise as timeout is not supported.
  • Log a warning when someone does it.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions