Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

--> in ng-repeat breaks the compilation #1740

Closed
@mhevery

Description

@mhevery

http://jsfiddle.net/XGpq4/

The issue is in ngRepeat:

        $compileNode = templateAttrs.$$element =
            jqLite('<!-- ' + directiveName + ': ' + templateAttrs[directiveName]  + ' -->');
        compileNode = $compileNode[0];

and it should be

        $compileNode = templateAttrs.$$element =
            jqLite(document.createComment(directiveName + ': ' + templateAttrs[directiveName]));

This in theory could allow of script injection.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions