select basic directive bug in firefox

[boblepepeur]

Hello, i think i found a bug in angular stable version 1.0.4 and unstable 1.1.4

in angular 1.0.4, line 14489 :

if (existingOption.element.selected !== option.selected) {
lastElement.prop('selected', (existingOption.selected = option.selected));
}
you test a bad properties of js option object
firefox rebuild the list every time on you have a bug onmouseover of the select option list

the good code is that :
if (existingOption.selected !== option.selected) {
lastElement.prop('selected', (existingOption.selected = option.selected));
}

[mbarlow]

I am experiencing the same problem in unstable 1.1.4.

[boblepepeur]

with my fix its working

Le 15 mai 2013 à 21:54, Michael Barlow notifications@github.com a écrit :

I am experiencing the same problem in unstable 1.1.4.

—
Reply to this email directly or view it on GitHub.

[mbarlow]

I implemented your change, and it is now working in Firefox 21.0. Thanks!

[boblepepeur]

Cool I am happy of helping you !!

Envoyé de mon iPhone

Le 15 mai 2013 à 22:47, Michael Barlow notifications@github.com a écrit :

I implemented your change, and it is now working in Firefox 21.0. Thanks!

—
Reply to this email directly or view it on GitHub.

[mgladdish]

What can we do to have this fix folded in to Angular? This bug has caused me pain in 1.0.7 and boblepepeur's fix works for me, too.

[pkozlowski-opensource]

@mgladdish - very simple - send a pull request with a fix and tests. This is the fastest way of having a bug fix propagated to the AngularJS code base.

[drewwarren]

A fix for this would be great. It is a pretty big annoyance on pages with real time data which cause digests very frequently.

I made a plunk of the issue: http://embed.plnkr.co/wuKBNc/preview. In firefox open the select box and then hover over any option other than 3.

The proposed fix introduces a regression with selects whose models have a value not in the options list. When you change the model value to be the first option the select will display the second options as selected.

[IgorMinar]

I can still repro this on FF 26 and angular 1.2.8: http://plnkr.co/edit/l8AB62?p=preview

[caitp]

The fix suggested by @boblepepeur fixes the flicker in the repro, but fails in other ways: If you remove the ng-init="selected = 3", you see that it fails to remove the NULL value and doesn't really clean up the selectable options, with that fix (indicated by failing the test should select correct input if previously selected option was "?"). So I guess it's not really a complete solution.

[kumarharsh]

+1
This bug is happening to me too...

For a long time I was suspecting firefox broke something, but then I didn't encounter the same bug in (of all places!!!) w3schools example, and then I stared to investigate... Never dawned on me that it could be Angular!

[kumarharsh]

Btw, I'm using Angular 1.2.4, and the bug is still present.