ngAnimate insertBefore error

[brianconnoly]

First I see this error

Then I go there

And do this

Problem solved till next angular.js update.
What am I doing? )

[petebacondarwin]

@brianconnoly - Can you provide the application code that triggers this error?

[brianconnoly]

It appears in several cases of using ng-repeat in manually compiled elements.
The app is quite big now.

[kiddkai]

using with ui-sortable , but it seems that ui-sortable works correctly, dono why have this issue

[ajshapiro]

I've experienced this as well since Angular 1.2.0-rc.3 when using ui-multi-sortable and jquery ui sortable. Not only is the insertBefore error generated, but the nodes are moved around improperly. I believe this is the same issue as #4786 and is the result of the addition of the addition of comments in 1.2.0-rc.3, which may be causing the default $AnimateProvider enter method to corrupt the ngRepeat output.

Here's a JSBin that replicates the problem. If you change the angular.js src to 1.2.0-rc.2 instead of 1.2.1, it works fine. Also removing the line in angular.js that adds the "end ngRepeat" comment also seemed to resolve the problem, although in the issue linked above, it is suggested that ngRepeat relies on those end comments, so not sure if this may cause other problems.

http://jsbin.com/asOXAXOz/1/edit?html,js,output

[CGenie]

@matsko: You can just as well move if(parentNode) outside of forEach, for performance reasons :)
Anyways, this seems to be ng-repeat-related. You're changing some function of ng-animate which I don't think is the full source of problems here.
Anyways, it would be best if you commited your change to some forked branch of yours and see if all Travis tests pass.

[matsko]

I will be taking a solid look at this once this once this PR gets in #5015. Thank you everyone for the detail and research put into it.

[matsko]

@brianconnoly sorry, but I had to change the milestone to 1.2.3 since there are a few other issues very similar to this one and I want to get them all fixed with the same patch. Version 1.2.3 shouldn't be longer than a week or two away from tomorrow.

[egrajeda]

Since this thread has more discussion than #4786, I just wanted to add that commit 9efa46a seems to be the cause of the problem.

[kamilkp]

I have the same problem, and a sample app where this error occurs: Issue #5054

[matsko]

@brianconnoly Just fixed a bunch of the comment-node issues with ngAnimate/animate.js. But this code looks like it's inside of ng/animate.js instead of ngAnimate/animate.js. Which means it's a core issue. The fix that you have in your screenshot is a great fix, I just need an example so I can craft a good test to isolate the bug.

[matsko]

@brianconnoly could you please answer my previous question?

[kamilkp]

Could you please say something in my issue too? #5054
You closed it already, but it doesn't seem closed to me.