This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(numberFilter): numbers rounding to zero shouldn't be negative #10278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLAs look good, thanks! |
|
LGTM |
|
Labeled it for 1.3.6, but if this lands today, please mark it as 1.3.5 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lgalfaso here is a little PR for the numberFilter that doesn't aim at changing the current code structure. My goal here was to share tests that I've added while looking at this filter code. IMO it would be good to get them in before doing bigger refactorings on this filter.
As a side effect this PR fixes inconsistency in formatting numbers that round to zero.
Once again, I'm not trying to clean up the whole code here but do minimal changes that fixes inconsistencies and bring in more tests. For me the value of this PR is in tests.