This repository was archived by the owner on Apr 12, 2024. It is now read-only.
perf(copy): use different arrays for different types #12065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use different arrays for different types. Remove forEach to clean the destination object.
|
using the same test at f7bf118, there is a 10% improvement |
|
I haven't created a PR yet but see ec8d488. It reduces the copy time by 30-60% while also splitting the method up similar to this. I didn't think of separate arrays though. But I'm not sure if it's worth the extra code and duplication imo. I'd still vote for using |
|
The use of |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use different arrays for different types.
Remove forEach to clean the destination object.