fix(ngResource): do not eat exceptions in success callback

src/ngResource/resource.js

@@ -784,18 +784,18 @@ angular.module('ngResource', ['ng']).
                 return value;
               },
               (hasError || hasResponseErrorInterceptor) ?
-              function(response) {
-                if (hasError) error(response);
-                return hasResponseErrorInterceptor ?
+                function(response) {
+                  if (hasError && !hasResponseErrorInterceptor) {
+                    // Avoid `Possibly Unhandled Rejection` error,
+                    // but still fulfill the returned promise with a rejection
+                    promise.catch(noop);
+                  }
+                  if (hasError) error(response);
+                  return hasResponseErrorInterceptor ?
                     responseErrorInterceptor(response) :
                     $q.reject(response);
-              } :
-              undefined);
-            if (hasError && !hasResponseErrorInterceptor) {
-              // Avoid `Possibly Unhandled Rejection` error,
-              // but still fulfill the returned promise with a rejection
-              promise.catch(noop);
-            }
+                } :
+                undefined);
 
             if (!isInstanceCall) {
               // we are creating instance / collection

test/ngResource/resourceSpec.js

@@ -1709,6 +1709,79 @@ describe('handling rejections', function() {
       expect($exceptionHandler.errors[0]).toMatch(/^Possibly unhandled rejection/);
     })
   );
+
+
+  it('should throw exception in success callback when error callback provided and no responseErrorInterceptor', function() {
+    $httpBackend.expect('GET', '/CreditCard/123').respond({ id: 123, number: '9876' });
+    var CreditCard = $resource('/CreditCard/:id:verb', { id: '@id.key' });
+    var cc = CreditCard.get({ id: 123 },
+      function(res) {
+        throw new Error('should be caught');
+      }, function() { });
+
+    $httpBackend.flush();
+    expect($exceptionHandler.errors.length).toBe(1);
+    expect($exceptionHandler.errors[0]).toMatch(/^Error: should be caught/);
+  });
+
+
+  it('should throw exception in success callback when error callback not provided and no responseErrorInterceptor', function() {
+    $httpBackend.expect('GET', '/CreditCard/123').respond({ id: 123, number: '9876' });
+    var CreditCard = $resource('/CreditCard/:id:verb', { id: '@id.key' });
+    var cc = CreditCard.get({ id: 123 },
+      function(res) {
+        throw new Error('should be caught');
+      });
+
+    $httpBackend.flush();
+    expect($exceptionHandler.errors.length).toBe(1);
+    expect($exceptionHandler.errors[0]).toMatch(/^Error: should be caught/);
+  });
+
+
+  it('should throw exception in success callback when error callback provided and has responseErrorInterceptor', function() {
+    inject(function($q) {
+
+      $httpBackend.expect('GET', '/CreditCard/123').respond({ id: 123, number: '9876' });
+      var CreditCard = $resource('/CreditCard/:id:verb', { id: '@id.key' }, {
+        'get': {
+          method: 'GET',
+          interceptor: { responseError: function() { return $q.reject({}); } }
+        }
+      });
+
+      var cc = CreditCard.get({ id: 123 },
+        function(res) {
+          throw new Error('should be caught');
+        }, function() { });
+
+      $httpBackend.flush();
+      expect($exceptionHandler.errors.length).toBe(1);
+      expect($exceptionHandler.errors[0]).toMatch(/^Error: should be caught/);
+    });
+  });
+
+
+  it('should throw exception in success callback when error callback not provided and has responseErrorInterceptor', function() {
+    inject(function($q) {
+
+      $httpBackend.expect('GET', '/CreditCard/123').respond({ id: 123, number: '9876' });
+      var CreditCard = $resource('/CreditCard/:id:verb', { id: '@id.key' }, {
+        'get': {
+          method: 'GET',
+          interceptor: { responseError: function() { return $q.reject({}); } }
+        }
+      });
+      var cc = CreditCard.get({ id: 123 },
+        function(res) {
+          throw new Error('should be caught');
+        });
+
+      $httpBackend.flush();
+      expect($exceptionHandler.errors.length).toBe(1);
+      expect($exceptionHandler.errors[0]).toMatch(/^Error: should be caught/);
+    });
+  });
 });
 
 describe('cancelling requests', function() {