Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

feature($resource): Add Resource To Response For Error Interceptors #16109

Closed
wants to merge 1 commit into from
Closed

feature($resource): Add Resource To Response For Error Interceptors #16109

wants to merge 1 commit into from

Conversation

kmccullough
Copy link
Contributor

@kmccullough kmccullough commented Jul 13, 2017

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Similar to how the resource object (which is to be populated later) is added to the response for a successful request and accessible to the response interceptor, this change attaches the resource object to the response for a failed request and is accessible by the responseError interceptor.

What is the current behavior? (You can also link to an open issue here)
The resource object is not accessible from the responseError interceptor.

What is the new behavior (if this is a feature change)?
The resource object is accessible from the responseError interceptor.

Does this PR introduce a breaking change?
No.

Please check if the PR fulfills these requirements

Other information:

Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add some docs for that. I think the behavior of adding resource to the response is not documented (and it should be).
(If you don't feel like adding the docs, it's OK 😃)

LGTM otherwise 👍

@kmccullough
Copy link
Contributor Author

@gkalpak How's that?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants