-
Notifications
You must be signed in to change notification settings - Fork 27.4k
fix($resource): functions in params should not be executed if overridden #6480
base: master
Are you sure you want to change the base?
Conversation
I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS. Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match. If you signed the CLA as a corporation, please let us know the company's name. Thanks a bunch! PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR. |
CLA signature verified! Thank you! Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes). |
I think this is a reasonable fix. @IgorMinar @caitp thoughts? |
On the surface it looks okay, for the use case which is tested, but I'd prefer if some other test cases were added to verify other ways it might be used. That's just my feeling based on a quick glance at the diff, though |
otherwise it looks good to me |
@IgorMinar done, amended commit. |
@btford is this still going ? |
02dc2aa
to
fd2d6c0
Compare
cad9560
to
f294244
Compare
8292c21
to
7b9fddf
Compare
4dd5a20
to
998c61c
Compare
No description provided.