Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix($resource): functions in params should not be executed if overridden #6480

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kilianc
Copy link

@kilianc kilianc commented Feb 27, 2014

No description provided.

@mary-poppins
Copy link

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@kilianc kilianc added cla: no and removed cla: yes labels Feb 27, 2014
@mary-poppins
Copy link

CLA signature verified! Thank you!

Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes).

@btford
Copy link
Contributor

btford commented Jun 10, 2014

I think this is a reasonable fix. @IgorMinar @caitp thoughts?

@btford btford added this to the Backlog milestone Jun 10, 2014
@btford btford self-assigned this Jun 10, 2014
@caitp
Copy link
Contributor

caitp commented Jun 10, 2014

On the surface it looks okay, for the use case which is tested, but I'd prefer if some other test cases were added to verify other ways it might be used. That's just my feeling based on a quick glance at the diff, though

@IgorMinar
Copy link
Contributor

otherwise it looks good to me

@kilianc
Copy link
Author

kilianc commented Jun 10, 2014

@IgorMinar done, amended commit.

@kilianc
Copy link
Author

kilianc commented Jul 2, 2014

@btford is this still going ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants