Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

angular.forEach passes object being iterated over as 3rd arg to callback #8108

Closed
wants to merge 1 commit into from
Closed

angular.forEach passes object being iterated over as 3rd arg to callback #8108

wants to merge 1 commit into from

Conversation

onlywei
Copy link
Contributor

@onlywei onlywei commented Jul 8, 2014

This is for consistency with native Array.prototype.forEach() API, and it is also sometimes useful!

@mary-poppins
Copy link

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

  • Uses the issue template (#8108)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@jbedard
Copy link
Collaborator

jbedard commented Jul 8, 2014

I agree #7902 :P

@mary-poppins
Copy link

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@onlywei onlywei added cla: no and removed cla: yes labels Jul 8, 2014
@onlywei
Copy link
Contributor Author

onlywei commented Jul 8, 2014

@jbedard Hah! I just learned how to search pull requests today. I'm OK with yours being merged. It looks great.

This is for consistency with native Array.prototype.forEach() API, and
it is also sometimes useful!
@mary-poppins
Copy link

CLA signature verified! Thank you!

Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes).

@onlywei onlywei added cla: yes and removed cla: no labels Jul 9, 2014
@Narretz
Copy link
Contributor

Narretz commented Jul 15, 2014

Okay, closing as dupe of #7902

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants